-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Buffers for cache records #26699
Comments
Since new format is incompatible, we need to use different cache keys. |
We can't detect it based on the payload or some other heuristic? |
don't we've a cache version? 🤔 we previously used that. can we use some magic bytes at buffer start to detect version? |
It's repository cache concept and it is located inside JSON which is not yet decoded at the moment of Buffer vs base64 decision |
what if we simply try to decode the new way and fallback to old way when failed? |
🎉 This issue has been resolved in version 37.421.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Describe the proposed change(s).
Encoding to
base64
was a bad idea, because it slows down cache writes about twice.Instead, we have to do
JSON.stringify
, compress it into a Buffer and then pass it directly to Redis or Cacache.The text was updated successfully, but these errors were encountered: