fix(cake): fix explicit registryUrl #26713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The full registryUrl is the combination of origin and pathname
viceice
changed the title
viceice
approved these changes
Jan 17, 2024
viceice
requested changes
Jan 17, 2024
also, I added another test case which I did not think of before.
viceice
approved these changes
Jan 18, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
🎉 This PR is included in version 37.140.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
zT-1337
pushed a commit
to scm-manager/renovate
that referenced
this pull request
Jan 22, 2024
zT-1337
pushed a commit
to scm-manager/renovate
that referenced
this pull request
Jan 24, 2024
zT-1337
pushed a commit
to scm-manager/renovate
that referenced
this pull request
Jan 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The full registryUrl is the combination of origin and pathname
Changes
The
registryUrlthat is parsed from the cake directives is changed from parsing it as theoriginto a combination oforiginandpathname.I consulted the
URLdocumentation to extract that this was the required properties.The fixture and expectations were modified accordingly.
Context
This is the fix for the problem described at #26684.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: