-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(versioning): same major #28418
feat(versioning): same major #28418
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we name it semver-same-major
or semver-coerced-same-major
?
Or at least the docs need to clarify that semver-coerced
versioning is used under the hood
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick, but not blocking
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs are hard to understand.
Please add some examples that explain how it works. Like maybe a diff of "old dependency" vs "proposed Renovate update".
Also focus on the reader, what problem is this feature fixing, how to use/configure it, and how to know if it's working as intended.
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some style fixes for the current text. I still find this hard to read and understand.
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
This reverts commit e2600ec.
Co-authored-by: Rhys Arkins <rhys@arkins.net>
🎉 This PR is included in version 37.418.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com> Co-authored-by: Michael Kriese <michael.kriese@visualon.de> Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com> Co-authored-by: Rhys Arkins <rhys@arkins.net>
Changes
Add a helper function
massageVersion
which massages single versions to constrains. eg.X.Y.Z
as>=X.Y.Z <X+1.0.0
Modify methods so that they can handle the version as a constraint and work as expected.
For eg.
matches
should returntrue
formatches('1.1.0', '1.0.0');
For more examples, please see the tests.
Context
Closes: #27312
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
https://github.com/Rahul-renovate-testing/same-major
First run without same-major versioning created 2 PRs:
i) for the highest version with same major as current version
ii) with the latest version
Second run with the same-major versioning and PR i) was autoclosed, which is the expected behaviour.