Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): log warning if using legacy encryption #28557

Merged
merged 5 commits into from
Apr 21, 2024
Merged

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Apr 21, 2024

Changes

Logs warning if using non-PGP encrypted variables.

Context

Preparation for removal of these options

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins
Copy link
Collaborator Author

rarkins commented Apr 21, 2024

I wonder if we can be more consistent on PGP vs GPG terminology.

GPG is an open source implementation PGP encryption. Technically it's still a "PGP key"?

viceice
viceice previously approved these changes Apr 21, 2024
viceice
viceice previously approved these changes Apr 21, 2024
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs test adaption or ignores.

@rarkins rarkins added this pull request to the merge queue Apr 21, 2024
Merged via the queue into main with commit ae1d892 Apr 21, 2024
37 checks passed
@rarkins rarkins deleted the feat/decrypt-warn branch April 21, 2024 14:08
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.315.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants