-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gerrit): commitBody
option not being effective
#28774
Conversation
@NiasSt90 if you can please take a look. |
54f6180
to
fb601b0
Compare
commitBody
setting not workingcommitBody
option not being effective
7e0e4f5
to
7610c6f
Compare
7610c6f
to
33ee987
Compare
`${prTitle}\n\nChange-Id: ${gerritChangeID}\n`, | ||
// Replace first line of the commit message with the new subject | ||
const newMessage = currentMessage.replace( | ||
new RegExp(`^.*$`, 'm'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new RegExp(`^.*$`, 'm'), | |
regEx(`^.*$`, 'm'), |
use our regex helper
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, will do it in the next patch.
🎉 This PR is included in version 37.334.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Changes
This fixes the
commitBody
setting inrenovate.json
being ignored/removed when Renovate needs to update the change subject on Gerrit.The previous code to update the commit message with the PR title was overriding the whole commit message with the new title. Now, it takes into account the previous commit message and only override its subject.
Context
I believe the issue is self-explanatory regarding the context.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: