Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(emoji): Use colorful version of warning emoji #28888

Merged
merged 8 commits into from
May 8, 2024

Conversation

zharinov
Copy link
Collaborator

@zharinov zharinov commented May 7, 2024

Changes

  • patch emojibase data for GitHub shortcodes: use colorful ⚠️ instead of (which looks cheap)
  • adjust the tranform logic accordingly
  • write tests to make sure it's safe

Warning: this PR could cause lots of updates for existing PRs

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov requested review from rarkins and viceice May 7, 2024 00:17
@rarkins rarkins requested a review from secustor May 7, 2024 05:45
rarkins
rarkins previously approved these changes May 7, 2024
lib/modules/platform/github/index.ts Show resolved Hide resolved
lib/util/emoji.ts Outdated Show resolved Hide resolved
@zharinov zharinov marked this pull request as draft May 7, 2024 11:56
viceice
viceice previously approved these changes May 7, 2024
@zharinov zharinov dismissed stale reviews from viceice and rarkins via f4882f4 May 7, 2024 12:10
@zharinov zharinov marked this pull request as ready for review May 7, 2024 12:11
@zharinov zharinov requested review from rarkins and viceice May 7, 2024 12:20
@rarkins rarkins added this pull request to the merge queue May 8, 2024
Merged via the queue into renovatebot:main with commit 51db0d9 May 8, 2024
37 checks passed
@rarkins rarkins deleted the fix/warning-emoji branch May 8, 2024 12:04
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.351.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants