-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(self-hosted): convert experimental env vars to config options #29154
feat(self-hosted): convert experimental env vars to config options #29154
Conversation
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Verified each migration locally, by either logging the values of each option at runtime or confirming that they are working as expected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small things, then good to go.
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go for me. But the maintainers should do the final review. 😉
Updated: Test complete 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs conflict resolution
@nabeelsaabna please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are only using RENOVATE_X_DELETE_CONFIG_FILE
🎉 This issue has been resolved in version 38.21.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Changes
RENOVATE_X_DELETE_CONFIG_FILE
deleteConfigFile
RENOVATE_X_S3_ENDPOINT
s3Endpoint
RENOVATE_X_S3_PATH_STYLE
s3PathStyle
There are some boolean types here. They could not be converted to
experimentalFlags
becauseGlobalConfig
hasn't been initialized yet, when they are used, hence converting them to self-hosted config options instead.Context
Last of: #27879 (comment)
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: