Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(asdf): Add rebar3 to asdf manager #29188

Merged
merged 3 commits into from
May 21, 2024
Merged

feat(asdf): Add rebar3 to asdf manager #29188

merged 3 commits into from
May 21, 2024

Conversation

kivra-pauoli
Copy link
Contributor

@kivra-pauoli kivra-pauoli commented May 21, 2024

Changes

This pull request adds support to bumping rebar entries in .tool-versions files, as supported by https://asdf-vm.com/.

Context

I saw rebar was not supported, and the change seems small enough for a first pull request.

Further considerations

Mind you that rebar3 is declared as rebar in .tool-versions but fetched from erlang/rebar3.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@kivra-pauoli
Copy link
Contributor Author

kivra-pauoli commented May 21, 2024

As per the comments in the pull request template I tried to sign the CLA in link https://cla-assistant.io/renovatebot/renovate, but I'm met with a mostly empty page. It's possible that approving the CI runs will show a different input.

image

Edit: the expected agreement has since been displayed and I was able to sign it.

rarkins
rarkins previously approved these changes May 21, 2024
@rarkins rarkins enabled auto-merge May 21, 2024 12:50
@rarkins
Copy link
Collaborator

rarkins commented May 21, 2024

@kivra-pauoli thanks for your PR and welcome to the repo!

auto-merge was automatically disabled May 21, 2024 13:37

Head branch was pushed to by a user without write access

@rarkins rarkins enabled auto-merge May 21, 2024 14:03
@rarkins rarkins requested a review from viceice May 21, 2024 14:03
@rarkins rarkins added this pull request to the merge queue May 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 21, 2024
@rarkins rarkins added this pull request to the merge queue May 21, 2024
Merged via the queue into renovatebot:main with commit 2e6c563 May 21, 2024
37 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.371.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kivra-pauoli kivra-pauoli deleted the feat/asdf-rebar branch May 22, 2024 13:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants