feat(gomod): Support go work vendor #29216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If go.work is present and a vendor/ is present, then the module is using go workspaces with vendoring, recently introduced with Go 1.22 (see golang/go#60056 for details). When using Go workspaces, you must use `go work vendor` instead of `go mod vendor`.
viceice
requested changes
May 22, 2024
|
@viceice PTAL |
viceice
reviewed
Jun 4, 2024
|
@viceice updated, PTAL |
chancez
force-pushed
the
pr/chancez/go_work_vendor
branch
from
3ff8444
to
90a60b8
Compare
|
@viceice I think this is ready to merge, let me know if you have any other changes you would like to see. Thanks! |
viceice
approved these changes
Jun 11, 2024
|
🎉 This PR is included in version 37.402.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
kosmoz
pushed a commit
to kosmoz/renovate
that referenced
this pull request
Jun 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Run
go work vendorinstead ofgo mod vendorif ago.workis present in the module. As of Go 1.22 (golang/go#60056) Go supports vendoring with workspaces. If ago.workis located in the module along with thevendordirectory,go mod vendorwill fail, sogo work vendoris needed instead.I also run
go work syncsince pretty likely users want their dependencies synced across all their modules in the repository. If this is undesirable, an option could be added to skip this step as well.Context
Relates to #29107. I wanted an option to disable the vendoring behavior entirely, but I figured making renovate run
go work vendorwould help more people, so I opted to do this instead.Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: