Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(platform/gitlab): handle assignee id not found #29307

Merged
merged 14 commits into from
Jun 4, 2024
Merged

fix(platform/gitlab): handle assignee id not found #29307

merged 14 commits into from
Jun 4, 2024

Conversation

RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh commented May 28, 2024 •
edited

Changes

  • throw a better error message incase ID for an assignee is not found
  • do not fail when one assignee not found, add the others

Context

Closes: #27943

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@RahulGautamSingh RahulGautamSingh marked this pull request as draft May 28, 2024 19:47
@RahulGautamSingh RahulGautamSingh marked this pull request as ready for review May 28, 2024 23:10
@RahulGautamSingh RahulGautamSingh added the auto:needs-details More details are required label May 28, 2024
@RahulGautamSingh RahulGautamSingh marked this pull request as draft May 28, 2024 23:40
@RahulGautamSingh RahulGautamSingh removed the auto:needs-details More details are required label May 31, 2024
@RahulGautamSingh RahulGautamSingh marked this pull request as ready for review June 4, 2024 02:19
rarkins
rarkins requested changes Jun 4, 2024
View reviewed changes
lib/modules/platform/gitlab/index.ts Outdated Show resolved Hide resolved
viceice
viceice reviewed Jun 4, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

lib/modules/platform/gitlab/http.ts Outdated Show resolved Hide resolved
@RahulGautamSingh @secustor
Update lib/modules/platform/gitlab/http.ts
942370e 
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
@rarkins rarkins added this pull request to the merge queue Jun 4, 2024
Merged via the queue into renovatebot:main with commit cb804b0 Jun 4, 2024
37 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.390.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

kosmoz pushed a commit to kosmoz/renovate that referenced this pull request Jun 12, 2024
@RahulGautamSingh @secustor @kosmoz
fix(platform/gitlab): handle assignee id not found (renovatebot#29307)
8793e90 
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins approved these changes

@secustor secustor Awaiting requested review from secustor

@viceice viceice Awaiting requested review from viceice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"failed to add assignee (Cannot read properties of undefined (reading 'id'))" on Gitlab self-hosted
5 participants
@RahulGautamSingh @renovate-release @viceice @rarkins @secustor