Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glasskube Support #29322

Closed
secustor opened this issue May 29, 2024 Discussed in #29206 · 6 comments · Fixed by #30774
Closed

Glasskube Support #29322

secustor opened this issue May 29, 2024 Discussed in #29206 · 6 comments · Fixed by #30774
Labels
new datasource New datasource support new package manager New package manager support

Comments

@secustor
Copy link
Collaborator

Discussed in #29206

Originally posted by kosmoz May 22, 2024

Tell us more.

Glasskube is a package manager for Kubernetes clusters. Glasskube and Glasskube packages can be managed via GitOps solutions, such as Flux or ArgoCD, in which case our users would love to get notified about updates directly in their repositories.

@secustor secustor added new package manager New package manager support new datasource New datasource support labels May 29, 2024
@renovatebot renovatebot deleted a comment from github-actions bot May 29, 2024
@kosmoz
Copy link
Contributor

kosmoz commented May 31, 2024

Hi, we (Glasskube) would love to contribute this feature!

Do you have any suggestions about where to best get started?

@rarkins
Copy link
Collaborator

rarkins commented May 31, 2024

Hi @kosmoz, that's great to hear! We recommend you implement in this order:

  • Datasource
  • Versioning
  • Manager

Datasource or Datasource+versioning won't be particularly useful on their own, although potentially someone could already use our custom manager with them for some value. However it simplifies things to work on them and merge incrementally. The final validation would be a real e2e repo test once the manager PR is ready.

For datasource, check out the readme and then it can be easiest if you pick an existing datasource which is similar and start by copy/pasting. Here was the most recent datasource addition for reference: #27971

@kosmoz
Copy link
Contributor

kosmoz commented Jun 6, 2024

I already started working on the versioning scheme in parallel to the datasource, but I'm not sure where to push my changes to best fit your workflow. Should I create a new PR based on main?

@rarkins
Copy link
Collaborator

rarkins commented Jun 6, 2024

Yea there should be no overlaps

@secustor
Copy link
Collaborator Author

secustor commented Jun 6, 2024

versioning should be merged first so we can set it as default in the datasource.

@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 38.45.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new datasource New datasource support new package manager New package manager support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants