Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default for configWarningReuseIssue to false #29504

Open
8 tasks
HonkingGoose opened this issue Jun 7, 2024 · 1 comment
Open
8 tasks

Change default for configWarningReuseIssue to false #29504

HonkingGoose opened this issue Jun 7, 2024 · 1 comment
Assignees
Labels
breaking Breaking change, requires major version bump priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code
Milestone

Comments

@HonkingGoose
Copy link
Collaborator

HonkingGoose commented Jun 7, 2024

Describe the proposed change(s).

Todos:

  • Set default setting for configWarningReuseIssue to false in the code.
  • Update the tests.
  • Update the configWarningReuseIssue config option docs.
  • Update outdated references to configWarningReuseIssue in the docs.
  • Write release note entry (developer commentary) for the v39 changelog:
    • Explain new default behavior
    • Explain why we changed the default: to stop users missing the configuration error warnings in a old re-opened issue.
    • Users can opt-out of this change, by setting configWarningReuseIssue to true, to keep the old behavior.

Creating this issue after approval from @rarkins in:

@HonkingGoose HonkingGoose added priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code breaking Breaking change, requires major version bump v38 labels Jun 7, 2024
@RahulGautamSingh
Copy link
Collaborator

Should we pass it to v39?

@viceice viceice added this to the v39 milestone Aug 2, 2024
@viceice viceice modified the milestones: v39, v40 Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change, requires major version bump priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code
Projects
None yet
Development

No branches or pull requests

4 participants