-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(instrumentation): add option to overwrite otlp service name/namespace/version with env var #29583
feat(instrumentation): add option to overwrite otlp service name/namespace/version with env var #29583
Conversation
Signed-off-by: Aviv Guiser <avivguiser@gmail.com>
Signed-off-by: Aviv Guiser <avivguiser@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please document this behavior change https://github.com/renovatebot/renovate/blob/main/docs/usage/opentelemetry.md
Signed-off-by: Aviv Guiser <avivguiser@gmail.com>
@secustor added docs |
Signed-off-by: Aviv Guiser <avivguiser@gmail.com>
Signed-off-by: Aviv Guiser <avivguiser@gmail.com>
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go, after @secustor
decides what to do with my review comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
🎉 This PR is included in version 37.406.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
…space/version with env var (renovatebot#29583) Signed-off-by: Aviv Guiser <avivguiser@gmail.com> Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
Changes
add the option to overwrite the following otlp attrributes
OTEL_SERVICE_NAME
OTEL_SERVICE_NAMESPACE
OTEL_SERVICE_VERSION
if one of those values is not set in as env var then a default is used (same as always was)
Context
closes #28986
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: