Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/gradle): Use dependencies task when generating verification metadata #29602

Conversation

raphiz
Copy link
Contributor

@raphiz raphiz commented Jun 11, 2024

Changes

As discussed here, use dependencies task when generating verification metadata.

Context

Currently, the help task is called to generate the verification-metadata.xml (e.g. ./gradlew --write-verification-metadata sha256 help). Gradle is lazy and may not evaluate the required dependencies:

[...] Gradle may discover more dependencies and artifacts depending on the tasks you execute. [...]

In my tests, using the built-in dependencies task instead of help works quite well (./gradlew --write-verification-metadata sha256 dependencies). The dependencies task is also called for lockfile generation.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first contribution and the investigation!

@secustor secustor added this pull request to the merge queue Jun 11, 2024
Merged via the queue into renovatebot:main with commit 8975c9b Jun 11, 2024
35 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.403.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

kosmoz pushed a commit to kosmoz/renovate that referenced this pull request Jun 12, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants