-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sbt-plugin): add new default registry URL #29648
fix(sbt-plugin): add new default registry URL #29648
Conversation
The bintray service has been sunset and now redirects to a mirror that no longer receives updates, so we should just default to maven.org as we do with sbt packages. See this page for additional context: https://www.scala-sbt.org/1.x/docs/Bintray-For-Plugins.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to verify that it still works with older plugins.
This repo is needed for plugins from 2021 or older. I've put it after the maven repo, because the maven repo is the default for newer plugins.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you check if there are readme files related to this change that need to be updated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs at least one test on a "real" repository to make sure it works end to end. This is the type of change which would pass all unit tests while stopping plugin updating working altogether if something were wrong
@HonkingGoose When I search for " @rarkins How should I test this on a "real" repository? Could you please elaborate? |
A public repo on github.com which needs updates affected by this PR. |
Here's a repo: https://github.com/george-wilson-rea/renovate-scala-plugins In |
Here's another repo, with an overridden sbt plugin config. Interestingly, sbt-scoverage is still not getting updated. I'm not sure what's going wrong here. |
Interestingly, it looks like sbt plugins are working by default, but for some reason |
Hmm, the convention is that each manager/datasource/platform has a readme file. Maybe the sbt-plugin has no readme yet. It should have a readme though! Please search in a similar directory for examples. 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a readme to both the datasource and manager.
@HonkingGoose The sbt manager has a readme saying
which is accurate. I have added some minimal readmes to the |
I've merged the latest suggestions from @zharinov, which has unfortunately dismissed the approving review. I've re-requested review per the contribution guidelines. Sorry for the churn. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some docs changes:
- Follow one sentence per line pattern
- Make a ordered list of the steps Renovate takes by default
- Small style fixes
Head branch was pushed to by a user without write access
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Head branch was pushed to by a user without write access
🎉 This PR is included in version 37.421.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Co-authored-by: Sergei Zharinov <zharinov@users.noreply.github.com> Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com> Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Changes
Change the default repository for SBT plugin lookup to
https://repo1.maven.org/maven2/
Context
The bintray service has been sunset and now
https://repo.scala-sbt.org/scalasbt/
redirects to a mirror that no longer receives updates. Renovate should just default to maven.org for sbt plugins as it does for sbt packages. See this page for additional context: https://www.scala-sbt.org/1.x/docs/Bintray-For-Plugins.htmlDocumentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: