Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub Alerts for Deprecated Dependency warnings #29689

Closed
HonkingGoose opened this issue Jun 15, 2024 · 1 comment
Closed

Use GitHub Alerts for Deprecated Dependency warnings #29689

HonkingGoose opened this issue Jun 15, 2024 · 1 comment
Labels
platform:github GitHub Platform priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)

Comments

@HonkingGoose
Copy link
Collaborator

HonkingGoose commented Jun 15, 2024

Describe the proposed change(s).

Blocked by:

Use GitHub's Alert styling to make the warning stand out more. Of course this will only work on GitHub. 😉 So something like this:

Warning

Renovate found the following deprecated dependencies:

  • Deprecated-stuff-1
  • Deprecated-stuff-2

You should review the listed dependencies, and either request a update from Renovate via this dashboard, or upgrade manually.

Here's the Markdown for the mock-up above:

> [!WARNING]
> Renovate found the following deprecated dependencies:
> 
> - Deprecated-stuff-1
> - Deprecated-stuff-2
>
> You should review the listed dependencies, and either request a update from Renovate via this dashboard, or upgrade manually.

Read the GitHub Docs, Basic writing and formatting syntax, Alerts for more information.

If [!WARNING] is too eye-catching, we can select a different alert level.

@HonkingGoose HonkingGoose added type:feature Feature (new functionality) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:blocked Issue is blocked by another issue or external requirement labels Jun 15, 2024
@HonkingGoose HonkingGoose added the platform:github GitHub Platform label Jun 15, 2024
@rarkins
Copy link
Collaborator

rarkins commented Jun 16, 2024

I'm already doing this as part of my PR #29694

FYI we can put this in source code which is valid on all platforms:

> ⚠ **Warning**\n> \n

And then our github platform massageMarkdown code massages it to this:

> [!WARNING]

@rarkins rarkins closed this as not planned Won't fix, can't repro, duplicate, stale Jun 16, 2024
@HonkingGoose HonkingGoose reopened this Jun 16, 2024
@HonkingGoose HonkingGoose removed the status:blocked Issue is blocked by another issue or external requirement label Jun 16, 2024
@HonkingGoose HonkingGoose changed the title Use GitHub Alerts for Deprecated Dependency warnings (blocked by 5098) Use GitHub Alerts for Deprecated Dependency warnings Jun 16, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform:github GitHub Platform priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

2 participants