fix(vulnerabilities): strip equals for nuget in Github alerts #29693
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
While testing a solution for #29600, I found that GitHub vuln alerts for nuget don't raise security fix PRs. This change strips
=
analogous to what was done before for maven and go, so that package rules become applicable to nuget deps.The underlying issue is that GitHub prefixes the version in the
vulnerableRequirements
field with=
, e.g.,vulnerableRequirements": "= 2.0.0",
eventually leading to package rules that include"matchCurrentVersion": "= 2.0.0"
. The beginning=
causes the rule never to match, resulting in no security fix PRs.Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
Test repo: https://github.com/renovate-demo/29600-github-vuln-alerts-nuget/pulls