Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vulnerabilities): do not force exact patch version in GitHub alerts #29700

Merged
merged 2 commits into from
Jun 16, 2024

Conversation

Churro
Copy link
Collaborator

@Churro Churro commented Jun 16, 2024

Changes

Relaxes the requirement of exact patch versions for security fix PRs that are generated based on GitHub vuln alerts.

istanbul ignore next is used to workaround a types issue with firstPatchedVersion. Due to

if (!alert.securityVulnerability.firstPatchedVersion) {
logger.debug(
{ alert },
'Vulnerability alert has no firstPatchedVersion - skipping',
);
continue;
}
alerts with missing patched versions are skipped early onwards.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Test repo: https://github.com/renovate-demo/29600-github-vuln-alerts/pulls

@rarkins rarkins added this pull request to the merge queue Jun 16, 2024
Merged via the queue into renovatebot:main with commit 99cc62f Jun 16, 2024
37 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.409.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub vulnerability alerts: do not limit to single version
3 participants