Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(presets/custom-managers): Add Makefile custom manager preset #29713

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

phil9909
Copy link
Contributor

Changes

Add a custom manager preset for Makefiles very similar to existing custom manager presets:

# renovate: datasource=node depName=node versioning=node
NODE_VERSION=18.13.0
# renovate: datasource=npm depName=pnpm
PNPM_VERSION = "7.25.1"
# renovate: datasource=npm depName=yarn
YARN_VERSION := '3.3.1'
# renovate: datasource=custom.hashicorp depName=consul
CONSUL_VERSION ?= 1.3.1

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

The documentation for custom manager preset is auto-generated, right?

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@phil9909
Copy link
Contributor Author

Thanks for the fast approval. How do we continue from here?

Should I update the branch?
Do features require multiple reviews?
Or is this ready to merge?

This is my first time contributing here. So I'm not sure how you handle such things, sorry.

@rarkins rarkins added this pull request to the merge queue Jun 18, 2024
@rarkins
Copy link
Collaborator

rarkins commented Jun 18, 2024

I was waiting in case there were other reviews, but I think it's fine to merge as it's opt-in. No need to update from main - it will be tested against a merge commit now before merging

Merged via the queue into renovatebot:main with commit 3b56439 Jun 18, 2024
37 checks passed
@phil9909 phil9909 deleted the makefile-custom-manager branch June 18, 2024 12:04
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.411.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants