Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecationWarningIssues functionality completely #29739

Closed
rarkins opened this issue Jun 18, 2024 · 2 comments · Fixed by #29743
Closed

Remove deprecationWarningIssues functionality completely #29739

rarkins opened this issue Jun 18, 2024 · 2 comments · Fixed by #29743
Assignees
@RahulGautamSingh
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code

Comments

@rarkins
Copy link
Collaborator

rarkins commented Jun 18, 2024

Describe the proposed change(s).

This functionality (create one issue per deprecated dependency) has been disabled for years and should be removed.

  • Remove the deprecationWarningIssues value but do not create config warnings if it's included in a user's config (massage it away)
  • Remove any code for creating deprecation issues

Do not make any changes which break the dependency dashboard deprecated warnings feature
@rarkins rarkins added priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code labels Jun 18, 2024
@RahulGautamSingh
Copy link
Collaborator

RahulGautamSingh commented Jun 18, 2024 •
edited
Loading

We will need to redo the default value of suppressNotifications config option as well. Should I set it to null? It should be done in a refactor before this issue.

@rarkins
Copy link
Collaborator Author

rarkins commented Jun 18, 2024

Yes, maybe null or []

@RahulGautamSingh RahulGautamSingh mentioned this issue Jun 18, 2024
Merged
6 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@RahulGautamSingh RahulGautamSingh

Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: remove old code related to deprecationWarningIssues RahulGautamSingh/renovate
2 participants
@rarkins @RahulGautamSingh