Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager): runtime version #29745

Merged
merged 15 commits into from
Jun 27, 2024
Merged

Conversation

setchy
Copy link
Collaborator

@setchy setchy commented Jun 18, 2024

Changes

Add new manager for runtime versions.

Initial focus is on python runtimes used by

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Example repository: https://github.com/setchy/renovate-heroku-runtime/pull/3

lib/modules/manager/heroku-runtime/index.ts Outdated Show resolved Hide resolved
lib/modules/manager/heroku-runtime/index.ts Outdated Show resolved Hide resolved
lib/modules/manager/heroku-runtime/extract.ts Outdated Show resolved Hide resolved
setchy and others added 2 commits June 18, 2024 15:19
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@setchy setchy requested a review from viceice June 18, 2024 20:28
Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the name as this file and content seemed to be used by other systems too.

https://www.koyeb.com/docs/build-and-deploy/build-from-git/python
https://docs.cloudfoundry.org/buildpacks/python/index.html

Is this maybe based on a common system?

@setchy
Copy link
Collaborator Author

setchy commented Jun 26, 2024

How interesting @secustor - I didn't realize that.

So perhaps this is better off generalized as a python-runtime manager

@setchy setchy changed the title feat(manager): heroku runtime feat(manager): python runtime Jun 26, 2024
@rarkins
Copy link
Collaborator

rarkins commented Jun 26, 2024

Can we make it a "runtime" manager more generically? If the python version always has a prefix, then in future there might be others, e.g. ruby-1.2.3 and we can then immediately accommodate them without a rename.

@setchy
Copy link
Collaborator Author

setchy commented Jun 26, 2024

Absolutely. renamed to runtime-version

@setchy setchy changed the title feat(manager): python runtime feat(manager): runtime version Jun 26, 2024
setchy and others added 2 commits June 26, 2024 16:37
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
@setchy setchy requested a review from secustor June 26, 2024 20:50
@rarkins rarkins added this pull request to the merge queue Jun 27, 2024
Merged via the queue into renovatebot:main with commit c14e30a Jun 27, 2024
37 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.420.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@setchy setchy deleted the feature/heroku-runtime branch June 27, 2024 01:16
bryannaegele pushed a commit to bryannaegele/renovate that referenced this pull request Jul 8, 2024
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants