Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(util/git): pass no-verify flag to deleteBranch #29749

Conversation

RahulGautamSingh
Copy link
Collaborator

Changes

  • Pass no-verify flag to the deleteBranch fn

Context

Closes: #29472

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository (tested locally)

@rarkins rarkins enabled auto-merge June 18, 2024 16:31
@rarkins rarkins added this pull request to the merge queue Jun 18, 2024
Merged via the queue into renovatebot:main with commit 4bc7414 Jun 18, 2024
37 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.412.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

deleteCommand.push('--no-verify');
}

await gitRetry(() => git.raw(deleteCommand));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonder why we use raw instead of push method 🤔

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gitNoVerify not being used for branch deletion
4 participants