Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support arbitrary file names for ansible-galaxy manager #29816

Open
rarkins opened this issue Jun 24, 2024 Discussed in #29800 · 0 comments
Open

Support arbitrary file names for ansible-galaxy manager #29816

rarkins opened this issue Jun 24, 2024 Discussed in #29800 · 0 comments
Labels
manager:ansible-galaxy Ansible Galaxy manager priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented Jun 24, 2024

Discussed in #29800

Originally posted by YinleXu June 21, 2024

What would you like help with?

I would like help with my configuration

How are you running Renovate?

Self-hosted

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

Gitlab, renovate version 37.408.0

Please tell us more about your question or problem

I have an ansible galaxy dependency file with name "requirements_galaxy.yml". This does not match the default pattern

"(^|/)(galaxy|requirements)(\\.ansible)?\\.ya?ml$"

Therefore I have added fileMatch config in the repo's renovate.json config file

"ansible-galaxy":{
    "fileMatch": ["(^|/)requirements_galaxy.ya?ml$"],
    "enabled": true
}

With this config, I can see the file being matched from the debug log but it seems it is not being treated as a package file. Therefore, no MR/PR was created for the dependencies in the file. See more details in the logs.

I have recreated the same issue with this Github repo. You can see the galaxy.ansible.yml file, which is matched by the default pattern, gets PRs created while requirements_galaxy.yml with same content did not. Although the file was actually matched evidently from the debug log.

Am I missing any config in addition to "fileMatch"?

Logs (if relevant)

Logs

DEBUG: Matched 2 file(s) for manager ansible-galaxy: galaxy.ansible.yml, requirements_galaxy.yml (repository=YinleXu/renovate_test)
DEBUG: Matched 1 file(s) for manager pip_requirements: requirements.txt (repository=YinleXu/renovate_test)
DEBUG: manager extract durations (ms) (repository=YinleXu/renovate_test)
       "managers": {"pip_requirements": 2, "ansible-galaxy": 2}
DEBUG: Found ansible-galaxy package files (repository=YinleXu/renovate_test)
DEBUG: Found pip_requirements package files (repository=YinleXu/renovate_test)
DEBUG: Found 2 package file(s) (repository=YinleXu/renovate_test)
 INFO: Dependency extraction complete (repository=YinleXu/renovate_test, baseBranch=main)
       "stats": {
         "managers": {
           "ansible-galaxy": {"fileCount": 1, "depCount": 4},
           "pip_requirements": {"fileCount": 1, "depCount": 2}
         },
         "total": {"fileCount": 2, "depCount": 6}
@rarkins rarkins added type:feature Feature (new functionality) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others manager:ansible-galaxy Ansible Galaxy manager labels Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
manager:ansible-galaxy Ansible Galaxy manager priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

1 participant