fix(datasource/go): support go proxy with abortOnError #29823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahippler
force-pushed
the
feature/go-abortOnError
branch
2 times, most recently
from
ce617ad
to
cfbacf0
Compare
viceice
changed the title
viceice
reviewed
Jun 24, 2024
ahippler
force-pushed
the
feature/go-abortOnError
branch
from
cfbacf0
to
9403c53
Compare
viceice
reviewed
Jul 9, 2024
auto-merge was automatically disabled
July 15, 2024 08:14
Head branch was pushed to by a user without write access
ahippler
force-pushed
the
feature/go-abortOnError
branch
from
9403c53
to
18cfdc1
Compare
viceice
approved these changes
Jul 15, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
🎉 This issue has been resolved in version 37.431.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Do not fail goproxy version lookup with
abortOnError: true.Context
The goproxy registry api only support listing versions per major version. Renovate tries to fetch the versions for the next major versions to be able to detect major version updated. This is repeated until the major version does not exist and the last requests fails with a 404. With abortOnError enabled the whole lookup throws an error for the last request. The logic to ignore the error does not handle the wrapper error.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: