Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only use GitHub releases to update Bazelisk #29847

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

mark-thm
Copy link
Contributor

Changes

Change Bazelisk to use GitHub Releases datasource instead of GitHub Tags datasource.

Context

Bazel's release process is to first create a tag, and then only to create a GitHub release once all artifacts have been built and are ready/available. The GitHub tag will exist before the real Bazel release artifacts are available, which causes Renovate to create PRs that may fail or only partially succed.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@mark-thm mark-thm changed the title Only use GitHub releases to update Bazelisk fix: Only use GitHub releases to update Bazelisk Jun 25, 2024
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the extract function also need changing

@mark-thm mark-thm requested a review from rarkins June 25, 2024 18:57
@rarkins rarkins added this pull request to the merge queue Jun 25, 2024
Merged via the queue into renovatebot:main with commit f70cbc6 Jun 25, 2024
37 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.417.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

bryannaegele pushed a commit to bryannaegele/renovate that referenced this pull request Jul 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants