Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cache): use rm.content to remove expired content #29860

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

RahulGautamSingh
Copy link
Collaborator

Changes

  • Use the combination of rm.content and rm.entry to remove the content from the disk and the entry from the index
  • Remove cacache.verify as it took longer than desriable to confirm that content is removed

we give up the guarantee that we clear any and all unwanted entries from the index/disk
but we do delete the expired content from the disk with certainity, which was the original intention I believe

Context

Closes: #29795

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@RahulGautamSingh RahulGautamSingh changed the title fix(cache): use rm.content to remove expired content refactor(cache): use rm.content to remove expired content Jun 26, 2024
@rarkins
Copy link
Collaborator

rarkins commented Jun 26, 2024

I tested this locally and got:

DEBUG: Checking file package cache for expired items
DEBUG: Deleted 113 of 192 file cached entries in 302ms

I don't have a "before" to compare it to

@rarkins rarkins added this pull request to the merge queue Jun 26, 2024
Merged via the queue into renovatebot:main with commit a829d96 Jun 26, 2024
37 checks passed
@RahulGautamSingh RahulGautamSingh deleted the fix-29795/rm-content branch June 26, 2024 11:47
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.418.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

bryannaegele pushed a commit to bryannaegele/renovate that referenced this pull request Jul 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleaning file-based package cache is slow, research if/when we need verify step
4 participants