Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create matchVisibility config option within packageRules #29871

Open
2 tasks
HonkingGoose opened this issue Jun 26, 2024 · 0 comments
Open
2 tasks

Create matchVisibility config option within packageRules #29871

HonkingGoose opened this issue Jun 26, 2024 · 0 comments
Labels
core:config Related to config capabilities and presets priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)

Comments

@HonkingGoose
Copy link
Collaborator

Describe the proposed change(s).

Todos

  • Add visibility field to RepoResult:
    export interface RepoResult {
    defaultBranch: string;
    isFork: boolean;
    repoFingerprint: string;
    }
  • Add new matchVisibility option to packageRules

Context

@rarkins commented:

I was thinking that we should migrate from private/public repo concepts to "visibility" public/private (and I think "internal" is an additional one for GitHub). Then we could add a matchVisibility option to packageRules

And followed-up with:

On second look I don't see the terms private/public in platform code, so maybe I misremembered.

I think we could do this:

  1. Add visibility field to RepoResult:
    export interface RepoResult {
    defaultBranch: string;
    isFork: boolean;
    repoFingerprint: string;
    }
  2. Add new matchVisibility option to packageRules

Related discussion

@HonkingGoose HonkingGoose added type:feature Feature (new functionality) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others core:config Related to config capabilities and presets labels Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core:config Related to config capabilities and presets priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

1 participant