Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release notes: Massage !123 markdown-links for GitLab platform - like Github #29934

Open
rarkins opened this issue Jun 29, 2024 Discussed in #29894 · 1 comment
Open

Release notes: Massage !123 markdown-links for GitLab platform - like Github #29934

rarkins opened this issue Jun 29, 2024 Discussed in #29894 · 1 comment
Labels
core:changelogs Related to changelogs/release notes fetching platform:gitlab GitLab Platform priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented Jun 29, 2024

Discussed in #29894

Originally posted by MaxWinterstein June 27, 2024
Currently there is a lot of massaging in the PR Description going on, like rewriting github.com references to github.com for backlink prevention and more.

The GitLab platform is missing this functionality which leads to e.g. wrong backlinks within the same repo:
When the changelog contains simple relative reference like !123 the Merge Request will ping his neighbour Merge Request with id 123, even it is years old.

(Originally posted as discussion #29892)

@rarkins rarkins added type:feature Feature (new functionality) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others platform:gitlab GitLab Platform core:changelogs Related to changelogs/release notes fetching labels Jun 29, 2024
@rarkins
Copy link
Collaborator Author

rarkins commented Jun 29, 2024

Renovate currently looks for #123 and not !123. The best thing we can do is wrap such patterns in backticks to prevent the linking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core:changelogs Related to changelogs/release notes fetching platform:gitlab GitLab Platform priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

1 participant