Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support automergeSchedule + platformAutomerge #29937

Open
rarkins opened this issue Jun 29, 2024 Discussed in #29899 · 0 comments
Open

Support automergeSchedule + platformAutomerge #29937

rarkins opened this issue Jun 29, 2024 Discussed in #29899 · 0 comments
Labels
core:automerge Relating to Renovate's automerge capabilities priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented Jun 29, 2024

Current docs noting the limitation: https://docs.renovatebot.com/configuration-options/#automergeschedule

Proposal: if automergeSchedule is defined then do not enqueue platform automerge immediately on PR creation, instead only enqueue it on a subsequent run when the branch looks "green".

One downside to this is that Renovate might need to always enqueue it every run, even if it keeps getting "kicked out" of the queue, because Renovate may not be able to determine that state. If so then this limitation needs to be clearly stated in updated docs.

Discussed in #29899

Originally posted by travisshivers June 27, 2024

Tell us more.

Using an automerge schedule doesn't work with GitHub merge queues since they require platformAutomerge. However, this means that it will try to automerge immediately ignoring the schedule.

Perhaps something that could make renovate only actually enable the platformAutomerge on the PR during the automerge window.

The automerge schedule for renovate is quite useful and I have a longer automerge schedule compared to the normal schedule such that it will keep the PR up-to-date with new versions for a human to merge sooner if they want.

@rarkins rarkins added type:feature Feature (new functionality) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others core:automerge Relating to Renovate's automerge capabilities labels Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core:automerge Relating to Renovate's automerge capabilities priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

1 participant