Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(manager/circleci): replace regex system with YAML parsing #30142

Merged
merged 3 commits into from
Jul 12, 2024
Merged

refactor(manager/circleci): replace regex system with YAML parsing #30142

merged 3 commits into from
Jul 12, 2024

Conversation

secustor
Copy link
Collaborator

Changes

Replace regex based parsing with a YAML parser based one including schema.

Context

Fixes this issue too: #29902

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@secustor secustor requested review from viceice and rarkins July 11, 2024 21:31
viceice
viceice reviewed Jul 12, 2024
View reviewed changes
lib/config/migration.ts Outdated Show resolved Hide resolved
lib/modules/datasource/npm/npmrc.ts Outdated Show resolved Hide resolved
lib/modules/manager/circleci/__fixtures__/config3.yml Show resolved Hide resolved
lib/modules/manager/gradle/parser/handlers.ts Outdated Show resolved Hide resolved
lib/modules/manager/npm/post-update/npm.ts Outdated Show resolved Hide resolved
lib/modules/manager/nuget/artifacts.ts Outdated Show resolved Hide resolved
@secustor secustor requested a review from viceice July 12, 2024 07:34
@secustor secustor enabled auto-merge July 12, 2024 07:34
viceice
viceice reviewed Jul 12, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@secustor secustor added this pull request to the merge queue Jul 12, 2024
Merged via the queue into renovatebot:main with commit 8d166a3 Jul 12, 2024
38 checks passed
@secustor secustor deleted the refactor/use-yaml-parser-circle-ci branch July 12, 2024 18:33
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 37.430.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tlbraams tlbraams mentioned this pull request Aug 2, 2024
Closed
6 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@rarkins rarkins Awaiting requested review from rarkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@secustor @renovate-release @viceice