refactor: rename platformOptions -> platformPrOptions #30173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The new option will need a new name |
Should I close this or is this still okay? |
|
Actually it's ok if the new one isn't publicly exposed for config yet |
viceice
previously approved these changes
Jul 15, 2024
viceice
approved these changes
Jul 15, 2024
This comment was marked as outdated.
This comment was marked as outdated.
|
🎉 This issue has been resolved in version 37.432.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Change the existing internal variable
platformOptionstoplatformPrOptionsso that we do not confused it with the to-be-added new optionplatformOptonsContext
Ref: #29716 (comment)
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: