-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(npm): append corepack hashes when updating package managers #30552
feat(npm): append corepack hashes when updating package managers #30552
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM outside of this nitpick and the already mentioned comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this hopefully doesn't interfere with the post update function of npm manager when grouping with other updates
https://github.com/Rahul-renovate-testing/30552-grp-updates |
Needs a double/triple check. I'm surprised that adding updateArtifacts() to the npm manager simply works and doesn't cause problems with its other artifacts updating. |
🎉 This issue has been resolved in version 38.41.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Changes
Add
updateArtifacts
fn inmanager/npm
which executes the commandcorepack use {depName}${newVersion}
if a package manager is being updatedContext
Closes: #28335
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
pnpm: https://github.com/Rahul-renovate-testing/repro
yarn: https://github.com/Rahul-renovate-testing/repro-yarn
npm: https://github.com/Rahul-renovate-testing/repro-npm