Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(npm): append corepack hashes when updating package managers #30552

Merged
merged 11 commits into from
Aug 19, 2024

Conversation

RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh commented Aug 1, 2024

Changes

Add updateArtifacts fn in manager/npm which executes the command corepack use {depName}${newVersion} if a package manager is being updated

Context

Closes: #28335

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

@RahulGautamSingh RahulGautamSingh changed the title feat(npm): add corepack hashes when updating package managers feat(npm): append corepack hashes when updating package managers Aug 1, 2024
Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM outside of this nitpick and the already mentioned comments.

lib/modules/manager/npm/artifacts.ts Outdated Show resolved Hide resolved
lib/modules/manager/npm/artifacts.ts Outdated Show resolved Hide resolved
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this hopefully doesn't interfere with the post update function of npm manager when grouping with other updates

lib/modules/manager/npm/artifacts.ts Outdated Show resolved Hide resolved
lib/modules/manager/npm/artifacts.ts Outdated Show resolved Hide resolved
@RahulGautamSingh
Copy link
Collaborator Author

RahulGautamSingh commented Aug 3, 2024

this hopefully doesn't interfere with the post update function of npm manager when grouping with other updates

https://github.com/Rahul-renovate-testing/30552-grp-updates
https://github.com/Rahul-renovate-testing/30552-grp-updates-yarn-range
https://github.com/Rahul-renovate-testing/30552-grp-updates-pnpm-range
Checked it here, the lockfile is updated correctly.

@rarkins
Copy link
Collaborator

rarkins commented Aug 4, 2024

Needs a double/triple check. I'm surprised that adding updateArtifacts() to the npm manager simply works and doesn't cause problems with its other artifacts updating.

lib/modules/manager/npm/artifacts.ts Outdated Show resolved Hide resolved
lib/modules/manager/npm/artifacts.ts Outdated Show resolved Hide resolved
lib/modules/manager/npm/artifacts.ts Outdated Show resolved Hide resolved
@rarkins rarkins enabled auto-merge August 14, 2024 07:24
@rarkins rarkins added this pull request to the merge queue Aug 19, 2024
Merged via the queue into renovatebot:main with commit c282113 Aug 19, 2024
38 checks passed
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 38.41.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm: Support updating packageManager digests
6 participants