Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename turbo repo #30818

Merged
merged 3 commits into from
Aug 16, 2024
Merged

fix: rename turbo repo #30818

merged 3 commits into from
Aug 16, 2024

Conversation

moltar
Copy link
Contributor

@moltar moltar commented Aug 16, 2024

Changes

Renames Vercel Turbo monorepo.

Turbo was added in #22393.

But since then Vercel must have renamed their repo, because that URL redirects to the one in this PR.

Context

The side effect of having the wrong URL, is that packages are not grouped correctly.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@moltar moltar marked this pull request as ready for review August 16, 2024 07:08
@rarkins
Copy link
Collaborator

rarkins commented Aug 16, 2024

How long ago was the renaming done? Should we have both for a period?

@moltar
Copy link
Contributor Author

moltar commented Aug 16, 2024

How long ago was the renaming done?

Don't know, tried to find this out, but didn't find any conclusive information.

I just observed on my repos that all of the packages were merged separately recently, but could have been for a while too, and I just didn't once.

Should we have both for a period?

That I cannot answer, as I am not too familiar with the Renovate ways.

How would that be done? An array of URLs? Or just under a different name?

@moltar
Copy link
Contributor Author

moltar commented Aug 16, 2024

This PR seems to change the URLs: vercel/turborepo#8965

@rarkins
Copy link
Collaborator

rarkins commented Aug 16, 2024

Then we need to have both repo URLs as part of this rule

@moltar
Copy link
Contributor Author

moltar commented Aug 16, 2024

Then we need to have both repo URLs as part of this rule

How to do that?

@rarkins
Copy link
Collaborator

rarkins commented Aug 16, 2024

Look at some of the lines below it for examples

@moltar
Copy link
Contributor Author

moltar commented Aug 16, 2024

Then we need to have both repo URLs as part of this rule

✅ Fixed

@rarkins rarkins added this pull request to the merge queue Aug 16, 2024
Merged via the queue into renovatebot:main with commit 6b102d2 Aug 16, 2024
38 checks passed
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 38.38.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants