Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support lein-parent as a dependency for clojure projects #7815

Closed
skaasten opened this issue Nov 25, 2020 · 8 comments
Closed

Support lein-parent as a dependency for clojure projects #7815

skaasten opened this issue Nov 25, 2020 · 8 comments
Labels
manager:leinigen priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)

Comments

@skaasten
Copy link

What would you like Renovate to be able to do?

Recognize parent-project as a dependency and check for updates on that version.

Lein-parent allows dependencies to be inherited from another project.

Did you already have any implementation ideas?

Possibly update the logic in https://github.com/renovatebot/renovate/blob/master/lib/manager/leiningen/extract.ts#L142 to look for the :parent-project key and add that as a dependency to be checked.

I could take a stab at implementing myself.

@viceice viceice added manager:leinigen type:feature Feature (new functionality) labels Nov 25, 2020
@rarkins
Copy link
Collaborator

rarkins commented Nov 25, 2020

Can you create an example repository to demonstrate what you mean? I assume the parent project is within the same repo?

@skaasten
Copy link
Author

Technically the parent-project can be in the same repo, but I think it would only be necessary to support external parents, such as this example.

@rarkins
Copy link
Collaborator

rarkins commented Nov 25, 2020

So is it the 4.0.0 that you expect to get updated?

@skaasten
Copy link
Author

Yes, that's correct.

@skaasten
Copy link
Author

Let me know if there's any more information needed to prioritize.

@rarkins
Copy link
Collaborator

rarkins commented Jan 11, 2021

This would be the file that needs changing: https://github.com/renovatebot/renovate/blob/master/lib/manager/leiningen/extract.ts

@HonkingGoose
Copy link
Collaborator

@skaasten do you still want to work on this? We could assign you to this issue, so that we know you would be working on it. But feel free to refuse, no pressure! 😄

@HonkingGoose HonkingGoose added priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others and removed priority-5-triage labels Mar 8, 2021
@skaasten
Copy link
Author

skaasten commented Mar 8, 2021

@skaasten do you still want to work on this? We could assign you to this issue, so that we know you would be working on it. But feel free to refuse, no pressure! 😄

😄 I have a work-around, so we can close this if no-one else is asking for it.

@rarkins rarkins closed this as completed Mar 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
manager:leinigen priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

4 participants