-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove flannel beta designation, make default cni #935
Merged
emosbaugh
merged 3 commits into
main
from
emosbaugh/sc-61608/make-flannel-default-cni-for-kurl
Feb 2, 2023
Merged
chore: remove flannel beta designation, make default cni #935
emosbaugh
merged 3 commits into
main
from
emosbaugh/sc-61608/make-flannel-default-cni-for-kurl
Feb 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laverya
previously approved these changes
Jan 27, 2023
rrpolanco
reviewed
Jan 27, 2023
Will this change also show Flannel as the default CNI plugin selection in the homepage? |
This will affect what is returned as the default https://github.com/replicatedhq/kURL-api/pull/132/files#diff-642326ae47571da6c4d7db3e0de55fec30d4893f12e9556f317593e9c9a56081R818 |
rrpolanco
previously approved these changes
Jan 27, 2023
emosbaugh
force-pushed
the
emosbaugh/sc-61608/make-flannel-default-cni-for-kurl
branch
from
February 1, 2023 21:31
b0ad8ec
to
7ed5d57
Compare
rrpolanco
reviewed
Feb 1, 2023
rrpolanco
previously approved these changes
Feb 1, 2023
Co-authored-by: Rafael Polanco <6497491+rrpolanco@users.noreply.github.com>
camilamacedo86
approved these changes
Feb 2, 2023
emosbaugh
deleted the
emosbaugh/sc-61608/make-flannel-default-cni-for-kurl
branch
February 2, 2023 13:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes Flannel beta designation.
Refers to Flannel in example specs rather than Weave in preparation for making Flannel the default CNI.