Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove flannel beta designation, make default cni #935

Merged

Conversation

emosbaugh
Copy link
Member

Removes Flannel beta designation.

Refers to Flannel in example specs rather than Weave in preparation for making Flannel the default CNI.

@emosbaugh emosbaugh requested a review from a team as a code owner January 27, 2023 20:51
@github-actions
Copy link

github-actions bot commented Jan 27, 2023

@github-actions github-actions bot temporarily deployed to preview January 27, 2023 20:54 Inactive
laverya
laverya previously approved these changes Jan 27, 2023
@github-actions github-actions bot temporarily deployed to preview January 27, 2023 21:15 Inactive
@rrpolanco
Copy link
Contributor

rrpolanco commented Jan 27, 2023

Will this change also show Flannel as the default CNI plugin selection in the homepage?

@emosbaugh
Copy link
Member Author

Will this change also show Flannel as the default CNI plugin selection in the homepage?

This will affect what is returned as the default https://github.com/replicatedhq/kURL-api/pull/132/files#diff-642326ae47571da6c4d7db3e0de55fec30d4893f12e9556f317593e9c9a56081R818

rrpolanco
rrpolanco previously approved these changes Jan 27, 2023
@emosbaugh emosbaugh force-pushed the emosbaugh/sc-61608/make-flannel-default-cni-for-kurl branch from b0ad8ec to 7ed5d57 Compare February 1, 2023 21:31
@github-actions github-actions bot temporarily deployed to preview February 1, 2023 21:34 Inactive
rrpolanco
rrpolanco previously approved these changes Feb 1, 2023
Co-authored-by: Rafael Polanco <6497491+rrpolanco@users.noreply.github.com>
@emosbaugh emosbaugh merged commit c137dd6 into main Feb 2, 2023
@emosbaugh emosbaugh deleted the emosbaugh/sc-61608/make-flannel-default-cni-for-kurl branch February 2, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants