feat: enable austere linter for kurl.sh. #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enables the kurl-api austere installer linter.
ricardomaraschini
changed the title
emosbaugh
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been introduced by this PR
Enables the kurl-api
austereInstaller linter.Why has been done
The new linter has been hidden behind this flag for a long time, in the past we had to hide it due of:
skip_validationflag implementation).cloudflare-workers.Since then the new linter has been enabled as part of the
kots-lintproject and became active in the vendor portal. This is an example of how the new linter complains are presented in the vendor portal:Impact
Even though the new linter may return multiple complaints at the same time
kurl.shinterface is prepared to receive only one complain at a time. Due to that limitation additional complains are being trimmed off bykurl-api. Allied to that theaustereflag is not known or used by any other project so the only usage will be done here, bykurl.sh. The test deployment available here does not show any issues.