-
Notifications
You must be signed in to change notification settings - Fork 70
Step 2 not displayed without warning when no values.yaml present #930
Comments
Thanks for opening this issue @Timoses and for giving Ship a spin. I was able to reproduce this, looks like the default Rook chart doesn't ship with a values.yaml as you identified. We can check into ways to do a little bit better job of detecting this, although I'd guess we're open to ideas on how we could handle the rook case where there is a preprocessing step to get a proper values.yaml in place. @Timoses since ship supports plain YAML, you may be able to work this by just pointing directly at a concateanted rook operator yaml file, like so
Note -- this is untested, and you might have to do some more there. It looks like the rook team has broken up all the rook YAML for different environments here, so you can't just |
I'm gonna call this a bug because we could message/detect this a little better. As stated, not sure if there's a catch-all for the "chart doesn't have a values.yaml file" case. |
I think that's a good idea. If a Slightly off-topic: Is it possible to ship init charts repositories? E.g. https://charts.rook.io/release . I tried it, but it shows the same behaviour. |
Expected behavior
Step 2 displays new screen
Actual behavior
Clicking 'Get Started' does nothing. Clicking it again goes to step 3 which says one still has to complete the previous step.
Information
Steps to reproduce the behavior
ship init https://github.com/rook/rook/tree/v1.0.0/cluster/charts/rook-ceph
4 -> Step 2 is not displayed
Additional Info
Could this be because of the
values.yaml.tmpl
file in the rook directory?I tested
ship init https://github.com/helm/charts/tree/master/stable/grafana
which does display the second step.Edit: I did rename it to values.yaml locally and it seems to work.
Would still be great if it was possible to use the upstream repository with ship!
The text was updated successfully, but these errors were encountered: