Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement SecurityChecker #171

Merged
merged 2 commits into from
May 25, 2020
Merged

Implement SecurityChecker #171

merged 2 commits into from
May 25, 2020

Conversation

karniv00l
Copy link
Contributor

No description provided.

@karniv00l karniv00l added this to the 0.3.0 milestone May 22, 2020
@karniv00l karniv00l requested a review from akondas May 22, 2020 14:33
@codecov
Copy link

codecov bot commented May 22, 2020 •
edited
Loading

Codecov Report

Merging #171 into scanner will increase coverage by 0.00%.
The diff coverage is 97.74%.

Impacted file tree graph

@@             Coverage Diff             @@
##             scanner     #171    +/-   ##
===========================================
  Coverage      99.86%   99.86%            
- Complexity      1273     1321    +48     
===========================================
  Files            215      220     +5     
  Lines           3613     3744   +131     
===========================================
+ Hits            3608     3739   +131     
  Misses             5        5
Impacted Files Coverage Δ Complexity Δ
...rity/SecurityChecker/SensioLabsSecurityChecker.php 96.77% <96.73%> (+96.77%) 34.00 <31.00> (+32.00)
src/Command/UpdateAdvisoriesDbCommand.php 100.00% <100.00%> (ø) 3.00 <3.00> (?)
src/Service/Security/SecurityChecker/Advisory.php 100.00% <100.00%> (ø) 3.00 <3.00> (?)
src/Service/Security/SecurityChecker/Package.php 100.00% <100.00%> (ø) 3.00 <3.00> (?)
src/Service/Security/SecurityChecker/Result.php 100.00% <100.00%> (ø) 2.00 <2.00> (?)
src/Service/Security/SecurityChecker/Versions.php 100.00% <100.00%> (ø) 5.00 <5.00> (?)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a103826...4ddb4e6. Read the comment docs.

@karniv00l karniv00l changed the title Implement Implement SecurityChecker May 22, 2020
@akondas akondas merged commit 39af728 into repman-io:scanner May 25, 2020
akondas pushed a commit that referenced this pull request May 28, 2020
@karniv00l @akondas
Implement SecurityChecker (#171)
5c15fc4 
* Implement SecurityChecker

* Remove unused class; Load advisories only when var is empty
karniv00l added a commit that referenced this pull request May 28, 2020
@akondas @karniv00l
Implement security scanner (#183)
8fdcdc6 
* Implement PackageScanner service (#170)

* Implement PackageScanner service

* Remove php 7.4.3 constant

* Implement SecurityChecker (#171)

* Implement SecurityChecker

* Remove unused class; Load advisories only when var is empty

* Add `repman:security:update-db` command to cron (#176)

* Add last scan result to package model (#177)

* Add last scan result to package entity

* Disable command output

* Get rid of html from read model

* Update db command (#178)

* Scan all packages when database is updated

* CR fixes

* Add expectations

* Fix update advisories database git command (#182)

* Fix update advisories database git command

* Add git config for buddy pipeline

Co-authored-by: Piotr Rogowski <piotr.rogowski0@gmail.com>
@karniv00l karniv00l deleted the add-sec-checker branch June 1, 2020 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akondas akondas akondas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@karniv00l @akondas