Add PackageSynchronize command #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #185 +/- ##
=========================================
Coverage 99.91% 99.91%
- Complexity 1299 1303 +4
=========================================
Files 217 218 +1
Lines 3691 3706 +15
=========================================
+ Hits 3688 3703 +15
Misses 3 3
Continue to review full report at Codecov.
|
akondas
reviewed
May 28, 2020
akondas
reviewed
May 28, 2020
| /** @var InMemoryTransport $transport */ | ||
| $transport = $this->container()->get('messenger.transport.async'); | ||
|
|
||
| self::assertCount(2, $transport->getSent()); |
There was a problem hiding this comment.
there is $this->fixtures->addPackage() before, but I've added $transport->reset() now so we are checking only what command is doing
akondas
reviewed
May 28, 2020
| @@ -124,7 +124,7 @@ public function testUpdateWhenRepoDontExist(): void | |||
| public function testThrowErrorWhenUpdateFails(): void | |||
| { | |||
| $this->expectException(ProcessFailedException::class); | |||
| $this->expectExceptionMessage('repository \'/tmp/repman/security-advisories-repo\' does not exist'); | |||
| $this->expectExceptionMessage("repository '{$this->repoDir}' does not exist"); | |||
akondas
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.