Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create user security read model - clean user domain #188

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

akondas
Copy link
Member

@akondas akondas commented Jun 1, 2020

better separation of concepts:

  • User entity is now clear (without symfony UserInterface)
  • Prevent lazy loading domain models in view
  • separate user security read model
  • fix problem with logout on password change

@akondas akondas requested a review from karniv00l June 1, 2020 12:48
@codecov
Copy link

codecov bot commented Jun 1, 2020

Codecov Report

Merging #188 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #188   +/-   ##
=========================================
  Coverage     99.91%   99.92%           
- Complexity     1303     1330   +27     
=========================================
  Files           218      221    +3     
  Lines          3706     3765   +59     
=========================================
+ Hits           3703     3762   +59     
  Misses            3        3           
Impacted Files Coverage Δ Complexity Δ
src/Security/UserChecker.php 100.00% <ø> (ø) 4.00 <0.00> (ø)
src/Controller/OAuth/BitbucketController.php 100.00% <100.00%> (ø) 6.00 <2.00> (ø)
src/Controller/OAuth/GitHubController.php 100.00% <100.00%> (ø) 6.00 <2.00> (ø)
src/Controller/OAuth/GitLabController.php 100.00% <100.00%> (ø) 6.00 <2.00> (ø)
src/Controller/OAuth/OAuthController.php 100.00% <100.00%> (ø) 12.00 <0.00> (ø)
src/Controller/Organization/MembersController.php 100.00% <100.00%> (ø) 14.00 <0.00> (ø)
src/Controller/Organization/PackageController.php 100.00% <100.00%> (ø) 42.00 <34.00> (+1.00)
src/Controller/OrganizationController.php 100.00% <100.00%> (ø) 39.00 <0.00> (ø)
src/Controller/UserController.php 100.00% <100.00%> (ø) 8.00 <0.00> (ø)
src/Entity/User.php 100.00% <100.00%> (ø) 31.00 <3.00> (-10.00)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0272653...0e3f01d. Read the comment docs.

@akondas akondas added this to the 0.3.0 milestone Jun 2, 2020
@karniv00l karniv00l merged commit 4896b1c into repman-io:master Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants