-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for showing all package versions. Refs #175. #208
Conversation
e2a2eee
to
e59d5c5
Compare
Codecov Report
@@ Coverage Diff @@
## master #208 +/- ##
============================================
- Coverage 99.82% 99.75% -0.07%
- Complexity 1412 1439 +27
============================================
Files 231 234 +3
Lines 4001 4091 +90
============================================
+ Hits 3994 4081 +87
- Misses 7 10 +3
Continue to review full report at Codecov.
|
Looks great to me, thanks for your time 🍻. |
Also a colleague of my suggested that it might be more logical to add a copy button for the
? |
This also sounds good 👍 |
e59d5c5
to
16f36be
Compare
Fixes:
|
de7fd7b
to
95c2674
Compare
@nickygerritsen After testing, I suggest you do one more thing: maybe we can add info when no versions are available:
and button Because currently all packages that have not been synchronized will have this page blank. The rest works fine. Good job 🍻 |
I will do the first thing then you can do the second, looks much better. |
95c2674
to
29e4703
Compare
🤦 Actually, we don't really need this extra table, after all, all available versions can be fetch from the metadata file |
But will it be fast enough? Also pagination is then less useful since we need to read and I can try to write a parser for this data. |
Actually, that's right, I saw 30MB files, that would kill rendering this page. Let's stay with what you managed to do now. If this does not work, we can always change this 😉 |
This is my little UI refactor: https://github.com/Lets-Talk-NL/repman/pull/1/files 😉 |
44c9117
to
9801526
Compare
Nice, merged and squashed |
Thanks @nickygerritsen |
In #175 there was a request to show the package versions. Since that is also a very useful feature for us, I have added this functionality.
Some notes / remarks:
dev-*
versions this is what you want but for other versions you might want to add^
or~
in front of it. Maybe only let one copy the version itself as well as a separate button to copy the package name?stable
boolean to version so we can show thedev-*
versions in a separate table?Some screenshots: