Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Package Details UX #298

Merged
merged 4 commits into from
Oct 15, 2020
Merged

Improve Package Details UX #298

merged 4 commits into from
Oct 15, 2020

Conversation

giggsey
Copy link
Contributor

@giggsey giggsey commented Oct 13, 2020

image

image

image

@codecov
Copy link

codecov bot commented Oct 13, 2020

Codecov Report

Merging #298 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #298   +/-   ##
=========================================
  Coverage     99.59%   99.59%           
  Complexity     1859     1859           
=========================================
  Files           287      287           
  Lines          5479     5480    +1     
=========================================
+ Hits           5457     5458    +1     
  Misses           22       22           
Impacted Files Coverage Δ Complexity Δ
src/Controller/OrganizationController.php 100.00% <100.00%> (ø) 41.00 <0.00> (ø)
src/Query/User/PackageQuery/DbalPackageQuery.php 100.00% <100.00%> (ø) 25.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4de6b5...74043fe. Read the comment docs.

@giggsey
Copy link
Contributor Author

giggsey commented Oct 13, 2020

I think the header should get a bit more consistent across these pages too.

"[Package name] [page]" with Package name being a link back to the Details.

Not sure about Package list being a button on each of those pages.

(Quick edit before I switch branch locally), possible nav:

image

@akondas
Copy link
Member

akondas commented Oct 14, 2020

Tested 👍, UX feels much better, thanks @giggsey.
I like your idea with small package button on the left. You can change this as well 😉

Link back to the package details from each Action page
@giggsey
Copy link
Contributor Author

giggsey commented Oct 14, 2020

image

image

Using JavaScript to format the numbers to allow for different locales without having to build support into the backend

@giggsey giggsey marked this pull request as draft October 14, 2020 11:58
Switch to extracting the text via Symfony, as that deals with HTML tags & whitespace
@akondas
Copy link
Member

akondas commented Oct 14, 2020

Nice, link to stats in package details is also good UX 👍

@giggsey giggsey marked this pull request as ready for review October 14, 2020 13:06
@giggsey giggsey changed the title Show Package Actions dropdown on every package page Improve Package Details UX Oct 14, 2020
@karniv00l karniv00l merged commit c43aacd into repman-io:master Oct 15, 2020
@giggsey giggsey deleted the actions branch October 15, 2020 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants