Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that latest version is not removed when limit is applied #312

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Ensure that latest version is not removed when limit is applied #312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Service/PackageSynchronizer/ComposerPackageSynchronizer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,11 @@ public function synchronize(Package $package): void
$version['distType']
);

if ($package->keepLastReleases() > 0 && count($encounteredVersions) >= $package->keepLastReleases()) {
if (
$latest->getVersion() !== $version['version']
&& $package->keepLastReleases() > 0
&& count($encounteredVersions) >= $package->keepLastReleases()
) {
$this->distStorage->remove($dist);
$package->removeVersion(new Version(
Uuid::uuid4(),
Expand Down
2 changes: 1 addition & 1 deletion src/Service/Security/PackageScanner/SensioLabsPackageScanner.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ private function findDistribution(Package $package): string
);

return $filename->getOrElseThrow(
new \RuntimeException('Distribution file not found')
new \RuntimeException("Distribution file for version $packageVersion not found")
);
}
}
Expand Down