Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make var/cache ephemeral #420

Merged
merged 1 commit into from
Mar 1, 2021
Merged

Conversation

karniv00l
Copy link
Contributor

Currently whole var/cache directory is mounted and shared between 3 containers:

  • app
  • consumer
  • cron

Only app is clearing and warming up the cache, but the problem is that there is no guarantee that app will actually start and finish clearing cache first before other containers will read it. This may cause issues like: #417

There is not much need to keep caches / sessions between restarts right now.

This change overrides app/var volume with /app/var/cache volume which effectively creates an empty directory in the container on every start. Also I don't see a need for warming up cache for each container.

@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #420 (c48c087) into master (12681c9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #420   +/-   ##
=========================================
  Coverage     99.38%   99.38%           
  Complexity     1863     1863           
=========================================
  Files           297      297           
  Lines          5871     5871           
=========================================
  Hits           5835     5835           
  Misses           36       36           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12681c9...c48c087. Read the comment docs.

@akondas akondas merged commit c50b53e into repman-io:master Mar 1, 2021
@karniv00l karniv00l deleted the docker-cache branch March 1, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants