Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"JSONDecodeError" is not intercepted in the "rp_responses.py" #244

Open
vlad-shulika opened this issue Nov 19, 2024 · 0 comments
Open

"JSONDecodeError" is not intercepted in the "rp_responses.py" #244

vlad-shulika opened this issue Nov 19, 2024 · 0 comments
Labels

Comments

@vlad-shulika
Copy link

Describe the bug
client-Python library can crash the execution process, if it wasn't able to decode responded JSON payload. The lib cannot intercept "JSONDecodeError" exception, since it's imported from the "json" package. But "requests" package can also raise "JSONDecodeError" exception from the "simplejson" package, if it's installed in the environment. Thus, both exception must be handled here: https://github.com/reportportal/client-Python/blob/develop/reportportal_client/core/rp_responses.py#L91

Steps to Reproduce

  1. Install "simplejson" with the client lib itself
  2. Return non-valid JSON payload from the ReportPortal server

Expected behavior
Both exception ("JSONDecodeError" from "json" and "simplejson" pcakges) must be handled here: https://github.com/reportportal/client-Python/blob/develop/reportportal_client/core/rp_responses.py#L91

Actual behavior
Only "JSONDecodeError" from "json" package is handled here: https://github.com/reportportal/client-Python/blob/develop/reportportal_client/core/rp_responses.py#L91

Package versions
reportportal-client==5.5.8

Additional context
Add any other context about the problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant