Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting affinity rules #432

Closed
fornhunkle opened this issue Nov 6, 2024 · 6 comments
Closed

Support setting affinity rules #432

fornhunkle opened this issue Nov 6, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@fornhunkle
Copy link

Recent updates allow setting replicaCount for deployments but the templates don't support setting affinity rules. In my case I want the pods running on different nodes.

Is this something you would consider adding?

If so, I could have a go at creating a PR for it.

Something along the lines of this for each deployment that can set replicas:

spec:
  template:
    spec:
      {{- with .Values.uat.affinity }}
      affinity: {{ toYaml . | indent 6 }}
      {{- end }}
@hlebkanonik
Copy link
Contributor

Hello! This is an open-source product, and a PR would be helpful. Thank you in advance!

@hlebkanonik hlebkanonik added the enhancement New feature or request label Nov 8, 2024
@hlebkanonik hlebkanonik self-assigned this Nov 8, 2024
@adrian-321
Copy link
Contributor

adrian-321 commented Nov 13, 2024

Hey @hlebkanonik I've raised a PR for this (different account)

The changes seem to be doing what I want locally but I don't have much experience with helm so please check it thoroughly

#436

@hlebkanonik
Copy link
Contributor

Hi! PR #436 has been merged into develop. The upcoming release of ReportPortal will include this change.

@adrian-321
Copy link
Contributor

awesome, thank you!

@CalebHenshaw
Copy link

When is the next release scheduled?

@hlebkanonik
Copy link
Contributor

hlebkanonik commented Dec 2, 2024

@CalebHenshaw, Jan 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants