Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce signed commits #420

Open
SamuelCabralCruz opened this issue Mar 6, 2021 · 3 comments · May be fixed by #439
Open

Enforce signed commits #420

SamuelCabralCruz opened this issue Mar 6, 2021 · 3 comments · May be fixed by #439

Comments

@SamuelCabralCruz
Copy link

Prerequisites:

image

New Feature

provide setting to enforce signed commits

@travi
Copy link
Member

travi commented Mar 7, 2021

please provide the remaining details asked for in the issue template

@johnmartel
Copy link

johnmartel commented Mar 25, 2021

@SamuelCabralCruz required_signatures should work. See: #220 (comment)

I did use it on a recent greenfield project and was working fine, BUT I do have occurrences of branch protection not being applied at all, with and without required_signatures being specified. I was not able to get down to the root of the issue so far. Would be interesting to be able to see error logs, maybe we could deploy our own instance of the app to get to the root of this.

@SamuelCabralCruz
Copy link
Author

@johnmartel I did check on your repo I forgot about this issue. It did work as expected. For the branch protection not being applied, I experienced the same issue but I observed that it seems to be due to partial branch protection configuration. Would be nice to do some further investigations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants