Fix HSTS header max-age value. #3225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NGPixel
approved these changes
Mar 19, 2021
jionggyu
pushed a commit
to jionggyu/wiki-2.5.302-patch
that referenced
this pull request
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wiki.js uses the wrong property to access the saved value for the max-age field of the Strict-Transport-Security HTTP response header. After enabling the "Enforce HSTS" option in the administration area, under the "Security" section, One would expect a new HTTP response header to be set like:
Strict-Transport-Security: max-age=600; includeSubDomainsInstead, this header is set:
Strict-Transport-Security: max-age=undefined; includeSubDomainsThis is invalid according to RFC 6797 and we cannot expect browsers to correctly apply the intended HSTS policy.
This PR fixes this.
I have tested this change with the current dev branch on one of my servers and it's working.