Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give some style to the preview component #53

Closed
rgreinho opened this issue Mar 15, 2018 · 4 comments
Closed

Give some style to the preview component #53

rgreinho opened this issue Mar 15, 2018 · 4 comments
Labels
exp/intermediate kind/enhancement

Comments

@rgreinho
Copy link
Member

Issue Type

  • Feature request

Expected Behavior

The preview component should do more than simply returning some text. It should show the user that an actual message is being generated.

Current Behavior

The text is simply dropped in the preview section of view1.

Possible Solution

Do some CSS magic.
@rgreinho
Copy link
Member Author

GitMate.io thinks possibly related issues are #10 (Turn the preview component into its own element), #8 (Create a style guide), and #12 (Create shared style to ensure design coherence).

@rgreinho
Copy link
Member Author

@chanduvkp is working on this issue.

@chanduvkp
Copy link
Contributor

created a branch with "issue/give-some-style-to-the-preview-component". Since this is logged as issue so prefixed with "issue"

@chanduvkp
Copy link
Contributor

@rgreinho - changes are commited in the branch named "bugfix/give-some-style-to-the-preview-component". Please review

@chanduvkp chanduvkp mentioned this issue Mar 30, 2018
Merged
@rgreinho rgreinho mentioned this issue Apr 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exp/intermediate kind/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chanduvkp @rgreinho