Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for python 3.7 #164

Closed
JWCook opened this issue Jul 23, 2023 · 2 comments · Fixed by #207
Closed

Drop support for python 3.7 #164

JWCook opened this issue Jul 23, 2023 · 2 comments · Fixed by #207
Labels
logistics CI builds, project config, refactoring, and other logistical details
Milestone

Comments

@JWCook
Copy link
Member

JWCook commented Jul 23, 2023

Python 3.7 is EOL, and it would make sense to drop support for it in the next minor release. That would allow several 3.7-specific workarounds to be removed.

If that would cause problems for anyone, please let me know.

@JWCook JWCook added the logistics CI builds, project config, refactoring, and other logistical details label Jul 23, 2023
@JWCook JWCook added this to the v0.9 milestone Jul 23, 2023
@JWCook JWCook modified the milestones: v0.9, v0.10 Sep 19, 2023
@JWCook JWCook modified the milestones: v0.10, v0.11 Oct 27, 2023
@alessio-locatelli
Copy link
Collaborator

alessio-locatelli commented Nov 20, 2023

I can do this in 1-2 weeks (because this issue is not urgent) unless you want to handle this by yourself.

aiohttp dropped 3.7 in aio-libs/aiohttp#7336 and released https://github.com/aio-libs/aiohttp/releases/tag/v3.9.0 two days ago.

By the way, it will be useful to add https://github.com/asottile/pyupgrade that auto-updates syntax to a specified Python version.

@JWCook
Copy link
Member Author

JWCook commented Nov 21, 2023

I started removing some workarounds for 3.7 in the integration tests (mostly just the ones that depend on AsyncMock). I'll submit what I have so far, and if you'd like you can add pyupgrade and make any other needed changes whenever you have the time? And yeah, it's definitely not urgent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logistics CI builds, project config, refactoring, and other logistical details
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants